That's what I meant in the comments
You could do it substr ($ hey, 0,2) check once and then the first two letters instead of several letters strpos, Maybe, but I have no idea what $ hey looks like 🙂 – but as you could counter Get rid of that and the multiple function calls. I do not think it will be much faster, but with enough iterations, who knows, and it may look a bit cleaner.
change (substr ($ hay, 0,2)) {
Case "na": // nasdaq
$ mk = & # 39; nasdaq-us & # 39 ;;
$ nasdaq ++
break;
Case # 39: // nyse
Case & # 39 ;: // New York
$ mk = & nbsp; nyse-us & # 39 ;;
$ nyse ++;
break;
Case # cb #: // cboe
$ mk = & # 39; cboe-us & # 39 ;;
$ cboe ++;
break;
Default:
$ mk = & # 39; market-us & # 39 ;;
$ others ++;
break;
}
This will do 1 function call instead of 4.
It looks like your calling strolinger more than 3 times $ cn
$ cn = strtolower (UpdateStocks :: slugCompany ($ s["quote"]["companyName"])); // s
// ...
$ p2 = sprintf (& # 39;% s% s% s & # 39; self :: SLASH, strtolower ($ cn), & # 39; - & # 39;);
// ...
if (strtolower ($ symb) === strtolower ($ cn)) {
// ------------------
$ p1 = sprintf (& # 39;% s% s% s & # 39; self :: SLASH, strtolower ($ symb), & # 39; - & # 39;);
if (strtolower ($ symb) === strtolower ($ cn)) {
And so on.
There may be more duplicate calls like these.
Your sprintf seem to show less.
// icon in the URL
$ p1 = sprintf (& # 39;% s% s% s & # 39; self :: SLASH, strtolower ($ symb), & # 39; - & # 39;);
// company in URL
$ p2 = sprintf (& # 39;% s% s% s & # 39; self :: SLASH, strtolower ($ cn), & # 39; - & # 39;);
// You could do this, for example
$ p1 = self :: SLASH. $ symb. & # 39; - & # 39 ;;
This whole piece is suspicious:
// icon in the URL
$ p1 = sprintf (& # 39;% s% s% s & # 39; self :: SLASH, strtolower ($ symb), & # 39; - & # 39;);
// company in URL
$ p2 = sprintf (& # 39;% s% s% s & # 39; self :: SLASH, strtolower ($ cn), & # 39; - & # 39;);
// Duplication Risk
if (strtolower ($ symb) === strtolower ($ cn)) {
// Duplicated name of a symbol
$ previousNames = array_reverse (UpdateStocks :: searchFilenames (glob ($ dir. "/ *"), $ p2));
$ lurl = $ cn. & # 39; - & # 39 ;. $ sc. & # 39; - & # 39 ;. $ mk. & # 39; - & # 39 ;. $ enc;
}otherwise{
// Duplicated name of a symbol
$ previousNames = array_reverse (UpdateStocks :: searchFilenames (glob ($ dir. "/ *"), $ p1));
$ lurl = strtolower ($ symb). & # 39; - & # 39 ;. $ cn. & # 39; - & # 39 ;. $ sc. & # 39; - & # 39 ;. $ mk. & # 39; - & # 39 ;. $ enc;
}
For example, the only difference is:
$ previousNames = array_reverse (UpdateStocks :: searchFilenames (glob ($ dir. "/ *"), $ p2));
$ previousNames = array_reverse (UpdateStocks :: searchFilenames (glob ($ dir. "/ *"), $ p1));
//and
$ lurl = $ cn. & # 39; - & # 39 ;. $ sc. & # 39; - & # 39 ;. $ mk. & # 39; - & # 39 ;. $ enc;
$ lurl = $ symb. & # 39; - & # 39 ;. $ cn. & # 39; - & # 39 ;. $ sc. & # 39; - & # 39 ;. $ mk. & # 39; - & # 39 ;. $ enc;
So if you can change and prepend the last argument $ symbMaybe you could eliminate this condition. I have to think about it a bit … lol. But you see, what I mean, it could be more DRY (do not repeat). I do not know enough about the data to really say anything. I thought something like this:
if ($ symb! = $ cn) {
$ p = self :: SLASH. $ symb. & # 39; - & # 39 ;;
$ lurl = & # 39; & # 39 ;;
}otherwise{
$ p = self :: SLASH. $ cn. & # 39; - & # 39 ;;
$ lurl = $ symb;
}
$ previousNames = array_reverse (UpdateStocks :: searchFilenames (glob ($ dir. "/ *"), $ p));
$ lurl. = "$ cn- $ sc- $ mk- $ enc";
But I'm not sure I got in the way. So definitely try it. A little hard to work only in my head. I still need a condition, but it is much shorter and easier to read.
For this:
search filenames
/ **
*
* @return an array with the path values of all stored front MD files
* /
public static function searchFilenames ($ array, $ re) {
$ arr = Array ();
foreach ($ array as $ k => $ str) {
$ pos = strpos ($ str, $ re);
if ($ pos! == false) {
array_push ($ arr, $ str);
}
}
return $ arr;
}
You can use preg_grep, For example:
public static function searchFilenames ($ array, $ re) {
return preg_grep (& # 39; / # 39; preg_quote ($ re, & # 39; / & # 39;). & # 39; / i & # 39 ;, $ array);
}
// or array_filter
public static function searchFilenames ($ array, $ re) {
return array_filter ($ array, function ($ item) use ($ re) {return strpos ($ re)! == false;});
}
They only find if $ re is contained in every element of $ array, preg_grep – Returns array entries that match the pattern, It is also independent of the I Flag. In any case, I never use array_push as $ arr[]= $ str is much faster. It's even better if you can easily modify the array, because this function is a copy anyway, since it is not passed as a reference.
One thing that I find useful is to include and add some sample data into the code in comments. Then you can imagine what transforms your work and whether you repeat yourself.
One last thing this fear a little bit:
foreach ($ previousNames as $ k => $ previousName) {
if ($ k == 0) {
// security: if the previous filename does not exactly match the new filename
rename ($ previousName, $ newName);
}otherwise{
// if several files were found: Unlink
unlink ($ previousName);
}
}
Here you check that $ k or the array key is 0It's very easy to reset array keys during sorting or filtering. So be careful, I think that this is a safer option.
foreach ($ previousNames as $ k => $ previousName) {
if ($ previousName! = $ newname) {
// security: if the previous filename does not exactly match the new filename
rename ($ previousName, $ newName);
}otherwise{
// if several files were found: Unlink
unlink ($ previousName);
}
}
Not sure if that was a mistake or I just do not understand this part? It's hard to be able to test without the value. However, it should be noted that the material is deleted as soon as it is deleted.
I hope it helps you, most of them are trifles.
